Standardize source-level with('multilabel') to single quotes#3521
Closed
GumpacG wants to merge 1 commit into
Closed
Standardize source-level with('multilabel') to single quotes#3521GumpacG wants to merge 1 commit into
GumpacG wants to merge 1 commit into
Conversation
…ll GLVs Assisted-by: Kiro:claude-opus-4.8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3521 +/- ##
============================================
+ Coverage 76.35% 76.39% +0.03%
- Complexity 13424 14265 +841
============================================
Files 1012 1036 +24
Lines 60341 64527 +4186
Branches 7075 7650 +575
============================================
+ Hits 46076 49296 +3220
- Misses 11548 12140 +592
- Partials 2717 3091 +374 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The source-level
with("multilabel")/with("singlelabel")clause was renderedwith double quotes in the GremlinLang output of every GLV, while all other string
arguments render with single quotes. This aligns it to single quotes so GremlinLang
output is internally consistent.
Before / after
Changes
Go, JavaScript, and .NET each render this clause in two places (
GremlinLangandGraphTraversalSource); both were updated.Assisted-by: Kiro:claude-opus-4.8